[Bug-1038] Align app forums contract

Story 1038Epic None7 files · +151/−127

PR #258 · pramaan-io/pramaan-functions · merged 2026-06-05

How it flows

sequenceDiagram
  autonumber
  participant dto as DTO
  participant svc as Service
  participant oas as OpenAPI spec
  participant tst as Contract test
  dto->>dto: Define ForumView
  svc->>svc: _view mapper
  dto->>oas: make openapi
  oas->>tst: assert shape

src/domains/forum/

Method	in → out	what it does
`ForumView`	`(class)`	timestamped response model with audit fields
`_view`	`(forum) → ForumView`	maps a Forum entity into the wire-shape view

What changed, file by file

src/domains/forum/service.py+11 −14

Adds a private helper that maps a Forum entity into the new ForumView shape, keeping app-facing responses aligned with the DTO.

new method	signature
`_view`	`(forum) → ForumView`

src/domains/forum/dtos/forum.py+8 −34

Replaces the old catalog-style DTO with a timestamped ForumView class carrying audit fields (archived_at, archived_by, created_by).

new class	signature
`ForumView`	`(class)`

New fields: archived_at : datetime | Nonearchived_by_user_id : UUID | Nonecreated_by_user_id : UUID | None

Off the table / Locked in

stale ForumListItem snapshot reappears
cross-repo fixture check against old app schema
integration test on local dev DB
pre-existing ruff / mypy noise
old catalog fields sneak back

DB-free OpenAPI test runs every CI

Catalog fields gone from spec

Downstream app regen still pending

Integration test blocked on DB role

Files changed (7)

File	±
`openapi/app-api.json` ★	+68 −61
`src/domains/forum/dtos/__init__.py`	+2 −8
`src/domains/forum/dtos/forum.py` ★	+8 −34
`src/domains/forum/service.py` ★	+11 −14
`tests/contract/generate_fixtures.py`	+8 −3
`tests/contract/test_app_forums_openapi.py`	+47
`tests/integration/test_app_forums.py`	+7 −7