[Bug-1051] Ungate forum settings actions after source removal

Story 1051Epic None17 files · +32/−143

PR #244 · pramaan-io/pramaan-app · merged 2026-06-06

How it flows

sequenceDiagram
  autonumber
  participant backend as Backend spec
  participant codegen as Codegen
  participant ui as Settings UI
  participant i18n as i18n
  participant verify as Verify
  backend->>codegen: OpenAPI sync from pramaan-functions main
  codegen->>codegen: pnpm codegen → src/gen regenerated
  codegen->>ui: ForumSource deleted, firmId required
  ui->>ui: Remove source column/pill, gate on canWrite
  ui->>i18n: Stale forum.source keys flagged
  i18n->>i18n: Remove keys from en.json and hi.json
  i18n->>verify: All checks triggered
  verify->>verify: lint, typecheck, 459 tests, build — green

Kya nahi hoga

Forum locked by stale source tag
Orphan i18n keys in en or hi locales
OpenAPI and generated code drift
Matter-types or filing-types source logic touched

canWrite is the single guard for forum row actions

459 tests, 84 files — all green

No system/firm discrimination remains for forums

Pre-existing i18n hardcoded-copy hits outside this diff remain

Other settings types (matter, filing) still source-aware by design

Files changed (17)

File	±
`docs/walkthroughs/bug-1051-forums.png`	+0
`messages/en.json`	+0 −3
`messages/hi.json`	+0 −3
`openapi/app-api.json` ★	+5 −25
`src/app/[locale]/(workspace)/settings/AGENTS.md` ★	+5 −3
`src/components/settings/forums/forums-fixtures.ts` ★	+6 −4
`src/components/settings/forums/forums-table.tsx`	+2 −22
`src/gen/index.ts`	+0 −2
`src/gen/schemas/forumListResponse.json`	+5 −14
`src/gen/schemas/forumSource.json`	+0 −7
`src/gen/schemas/forumView.json`	+5 −11
`src/gen/types/ForumSource.ts`	+0 −13
`src/gen/types/ForumView.ts`	+3 −8
`src/gen/types/index.ts`	+0 −1
`src/gen/zod/forumSourceSchema.ts`	+0 −17
`src/gen/zod/forumViewSchema.ts`	+1 −9
`src/gen/zod/index.ts`	+0 −1